Conversation
3 tasks done
zzylol
force-pushed
the
stack/cleanup-5-port-selection-tests
branch
from
October 5, 2026 03:07
67ba774 to
d5313d6
Compare
zzylol
force-pushed
the
stack/cleanup-4-ir-bins
branch
from
October 5, 2026 03:07
45fde63 to
4761c3e
Compare
This was referenced Oct 5, 2026
Tests that used the legacy global_selection only to obtain a selected DAG to execute or inspect now take the plan the #509 stage pipeline selects, through a small per-crate selected_dag helper. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
zzylol
force-pushed
the
stack/cleanup-4-ir-bins
branch
from
October 5, 2026 06:21
4761c3e to
0ba3310
Compare
zzylol
force-pushed
the
stack/cleanup-5-port-selection-tests
branch
from
October 5, 2026 06:21
d5313d6 to
01d3e54
Compare
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack: #574 → #620 → #618 → #621 → #627 → #625 → #628 → #632 → #634 → #616 → #617 → #622 → #624 → #629 → #630 → #631 → #633 → #635 → #636 → #637
Problem
Many tests used the legacy
candidate_selection::global_selection(plusassemble_selected_dag) only to get a selected DAG to execute or inspect (Q52). That kept the legacy selection alive and tested plans the planner no longer selects.Changes
These tests now take the plan the #509 stage pipeline selects (
plan_stages, one root, run once over a continuously ingested source, with the built-in models). The selection goes through a smallselected_dag(root, accuracy)helper in each test crate's existing shared module:executor/tests/common(reference-executor capabilities)integration-tests/tests/executor_modelsfrontend-promql/tests/support.rscfg(test)fixture inexecutor/src/physical_planner/candidates.rs, which callsplan_stagesinlinePorted: executor
deployment_computation,planspace_series_identity_heap,precompute_candidates,promql_fallback,tumbling_pane_merge,physical_planner/candidates.rs; frontend-promqlcount_planning,univmon_candidates; integration-testsoperator_sharing,precompute_raw_samples,sql_to_physical; plannersummary_sharing.Legacy search calls (
search_workload*,ASAPStrategies) that these files use for other assertions are untouched. They belong to the legacy-search deletion (Q52 step 7).Assertions that only held for legacy behaviour
deployment_computation::per_series_average_divides_stored_sum_by_count: Stage 1 has no avg → sum/count rewrite (that was the legacyAvgToSumOverCountStrategy), soavg_over_timenow selects the raw PromQL fallback. The test now planssum_over_time(m[5m]) / count_over_time(m[5m]), which still divides stored per-series sum and count states and drops the name. The overflow assertion is dropped: it checked the avg accumulator's checked division, which a Stage 1 plan never reaches (inf / nisinf, not an error).promql_fallback::histogram_quantile_selection_keeps_the_exact_fallback: the legacy search kepthistogram_quantilewhole. Stage 3 keeps it exact (no sketch, still asserted for both targets), but undersum by (le, job)it selects an exact Sum accumulator below the quantile. This whole-expression fallback harness can't bind that plan, so only the raw-bucket query is executed (still 1.75).count_planning/univmon_candidates: "the chosen candidate never has missing accuracy evidence" becomes "the selected plan contains no Hydra state" and "no UnivMon state", the families whose candidates lacked evidence.operator_sharing::each_side_of_union_all_holds_a_summary_estimate: now#[ignore]d with the same reason as the other Pass 2 sharing and Stage 1 coverage parity with the retired MajorPass #580 ignores. Stage 3 selects the raw plan, because query-time summaries never cost less until Stage 2 plans materialization.planner/tests/summary_sharing::certified_frequency_evaluations_share_one_univmon_state: deleted. It ran the legacy search and selection with a UnivMon-preferring cost model, and its stage-pipeline counterpartfrequency_moments_share_one_univmon_in_the_stage_pipelinealready covers the behaviour.PREFER_UNIVMONgoes with it.Stacked on #624.
Test plan
cargo fmt --all --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspace: 1610 passed, 0 failed, 14 ignored (after the rebase on main d4869a7; was 1607 passed, 14 ignored)🤖 Generated with Claude Code