Conversation
3 tasks done
zzylol
force-pushed
the
stack/cleanup-4-ir-bins
branch
from
October 5, 2026 03:07
45fde63 to
4761c3e
Compare
zzylol
force-pushed
the
stack/cleanup-3-legacy-cost
branch
from
October 5, 2026 03:07
7e08c9d to
281858b
Compare
This was referenced Oct 5, 2026
show_post_asap_ir ranked candidates with the legacy cost model; stage_pipeline shows how the planner plans a query. show_pre_asap_ir becomes show_logical_dag, the name of what it prints. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
zzylol
force-pushed
the
stack/cleanup-3-legacy-cost
branch
from
October 5, 2026 06:21
281858b to
84e9cfd
Compare
zzylol
force-pushed
the
stack/cleanup-4-ir-bins
branch
from
October 5, 2026 06:21
4761c3e to
0ba3310
Compare
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack: #574 → #620 → #618 → #621 → #627 → #625 → #628 → #632 → #634 → #616 → #617 → #622 → #624 → #629 → #630 → #631 → #633 → #635 → #636 → #637
Problem
show_post_asap_irprinted Post-ASAP candidates in legacy cost-model order (Q51).stage_pipelineshows how the planner actually plans a query.show_pre_asap_irprints the logical DAG a front end produces, and the new name says that.Changes
crates/devtools/src/bin/show_post_asap_ir.rs.show_pre_asap_irtoshow_logical_dag. Its header now points tostage_pipelinefor planning instead of toshow_post_asap_ir.docs/user_guide_docs/run-a-query.md: drop theshow_post_asap_irtable row, the "Inspect Post-ASAP IR candidates" section and theshow_post_asap_irmentions; useshow_logical_dagthroughout.docs/develop_docs/library-api.md: update the CLI example link.crates/devtools/Cargo.toml: dependency comment names the current bins.Stacked on #622.
Test plan
cargo fmt --all --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspace: 1612 passed, 0 failed, 13 ignored (after the rebase on main d4869a7; was 1609 passed, 13 ignored)🤖 Generated with Claude Code