Conversation
This was referenced Oct 4, 2026
zzylol
force-pushed
the
stack/cleanup-1-dag-export-bin
branch
from
October 5, 2026 03:07
1223aa3 to
4af8f07
Compare
zzylol
changed the base branch from
stack/509-viewer-stages
to
stack/windows-2-segments
October 5, 2026 03:08
This was referenced Oct 5, 2026
Its export path ran the legacy PhysicalPlanCostModel, which Stage 3 does not use; stage_pipeline replaces it for inspection. The lost evidence-changes-selection coverage is tracked in #615. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
zzylol
force-pushed
the
stack/cleanup-1-dag-export-bin
branch
from
October 5, 2026 06:21
4af8f07 to
e134bfd
Compare
zzylol
changed the base branch from
stack/windows-2-segments
to
stack/windows-4-segment-grid
October 5, 2026 06:21
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack: #574 → #620 → #618 → #621 → #627 → #625 → #628 → #632 → #634 → #616 → #617 → #622 → #624 → #629 → #630 → #631 → #633 → #635 → #636 → #637
Problem
The
dag_exportdevtool bin exported query DAGs through the legacyPhysicalPlanCostModel, which the Stage 3 pipeline doesn't use.stage_pipelinenow covers inspection. Its tests were the only coverage showing that storage-I/O and hand-off evidence change plan selection. That coverage is tracked in #615 ("Stage 3: evidence-driven cost (storage I/O, hand-off bytes)").Changes
crates/devtools/src/bin/dag_export.rs.docs/user_guide_docs/run-a-query.md: drop thedag_exporttable rows and the "Export a query DAG" section.docs/develop_docs/storage-operation-costs.md,physical-handoff-costs.md: drop thedag_export --planner-cost-jsonsentences and thecargo test --bin dag_exportverification commands.dag_exportcomment references incrates/devtools/Cargo.tomlandsketch_coverage.rs.First of a stacked cleanup chain (Q50–Q53).
Test plan
cargo fmt --all --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspace: 1665 passed, 0 failed, 13 ignored (after the rebase on main d4869a7; was 1662 passed, 13 ignored)🤖 Generated with Claude Code