Conversation
After the legacy search was removed, nothing reads planning-time accuracy evidence. Delete AccuracyEvidenceProvider, NoAccuracyEvidence, WorkloadAccuracyEvidence, EstimatorContract, QuantileInputDomain, PlanningModels.evidence / with_evidence, and ClassicHllConfidence, which only an EstimatorContract could reach. PropagationStats keeps the two Hydra shared-grid fields hydra_guarantee reads and moves next to it. The generic HLL estimator Stage 3 uses is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
zzylol
force-pushed
the
stack/cleanup-12-evidence-api
branch
from
October 5, 2026 13:11
0b88697 to
b517fbf
Compare
zzylol
changed the base branch from
stack/cleanup-11-docs
to
stack/fix-nested-topk-keys
October 5, 2026 13:11
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack: #574 → #620 → #618 → #621 → #627 → #625 → #628 → #632 → #634 → #616 → #617 → #622 → #624 → #629 → #630 → #631 → #633 → #635 → #636 → #637 → #638 → #640 → #641
Rebased onto #640. At this head
cargo fmt --all --check, clippy-D warningsandcargo test --workspacepass (1277 passed, 0 failed, 13 ignored); viewer tests OK.Problem
After the legacy search was removed (#635), the planning-time accuracy-evidence API has no reader.
PlanningModels.evidencewas stored but never read: no stage pipeline code (Stage 1 logical_candidates/pass2, Stage 3 plan_stages/build_violation/answers/satisfies, executor, frontends, devtools stage_pipeline, facade) calls a provider method. Removing the items and building the whole workspace (all targets) confirms it.Changes
Deleted:
PlanningModels.evidenceandwith_evidence.PlanningModels::new(accuracy, evidence)becomesnew(accuracy).accuracy/evidence.rs:AccuracyEvidenceProvider,NoAccuracyEvidence,WorkloadAccuracyEvidence(and its test),EstimatorContract,QuantileInputDomain, along with the crate-root andaccuracyre-exports.ClassicHllConfidenceand its 4 tests. Only anEstimatorContract::ClassicHllcould reach it, and nothing produced one.Kept:
hll::generic_guarantee,hll_precision), which Stage 3 uses throughlocal_guarantee.PropagationStats, whichhydra_guaranteereads. It is now apub(crate)struct inaccuracy/estimators/mod.rswith only the two Hydra shared-grid fields that are read. The other fields were filled only by the provider or by nothing: quantile ratio domains, row count, distribution, TopK intervals, non-negative proof and evidence provenance.Docs: I removed the
evidencerow fromlibrary-api.md, and made short factual edits toinput-output-workflow.md,accuracy-models.md(evidence section, and the Classic HLL example replaced with a short HLL-confidence note) andend-to-end-accuracy-guarantees.md. Two docs already marked historical (evidence-dependent-candidates.md,ddsketch-quantile-ratios.md) still mention the old names and are left as they are.For a later decision (not changed here)
MaintainedPopulationStrategy::candidate(pass1/maintained_population.rs) is reachable from no planner path. Only tests call it, in logical-optimizer, frontend-sql, frontend-promql and executor. Stage 2 rejects maintained populations (reject_maintained_populations). It is left in place for a separate decision.Test plan
cargo fmt --all -- --check: cleancargo clippy --workspace --all-targets -- -D warnings: cleancargo test --workspace: 1275 passed, 0 failed, 14 ignored (123 suites). The 5 removed tests were the evidence and classic HLL tests.🤖 Generated with Claude Code