Repository navigation
Add GitHub Actions CI build on every PR - #68
Merged
Merged
Conversation
Builds the OpenVision scheme with build-for-testing for a generic iOS device with code signing disabled, on the free macos-26 runner, so a PR that doesn't compile is caught before review. Copies the example xcconfig into place, caches SwiftPM checkouts keyed on the project pins, pins Xcode 26.6 via DEVELOPER_DIR, and uploads xcactivitylogs when the build fails. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The first run failed at "Validate plug-in CudaBuild in package mlx-swift": Xcode won't run third-party build plugins or macros unapproved, and CI has no one to approve them. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Second run got through package resolution and the MLX targets and stopped only on the other gitignored file the README has contributors copy. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This was referenced Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Until now nothing compiled a PR before a human read it; the only check was CodeRabbit. This adds a GitHub Actions workflow that builds the app and its test target on every pull request and push to
main, plus a CI badge in the README.xcodebuild build-for-testingforgeneric/platform=iOSwith code signing off. That proves the code compiles against the iOS SDK without certificates, and it matches how the app is actually run (on a phone; the simulator can't do Bluetooth or on-device MLX).macos-26runner, which is free for public repositories. Larger runners are billed even on public repos, so the job stays on the plain label..exampleversions, the same two the README asks contributors to create; the placeholder values are enough to compile.-skipPackagePluginValidationand-skipMacroValidation: mlx-swift ships a build plugin (CudaBuild) and mlx-swift-lm uses Swift macros, and Xcode refuses both until a human approves them.project.pbxproj+project.yml, sincePackage.resolvedis gitignored.DEVELOPER_DIRso an image update can't change the SDK under a PR..xcactivitylogfiles when the build fails.What the first runs showed
CudaBuildplugin; run 2 on the missingConfig.swift. Both are fixed in this branch and documented in the workflow comments.mlx-swift-lmpin was chosen for the Xcode 27 SDK (Fix: Bump mlx-swift-lm pin so the project builds on Xcode 27 #59).MLXFoundationModelscompiled cleanly on 26.6, so the pin works on both. When Xcode 27 reachesactions/runner-images, bumpDEVELOPER_DIR.Follow-ups (separate PRs)
mainonce this is merged and the open PRs have had a run.🤖 Generated with Claude Code