Repository navigation
Conversation
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
rwgk
added this pull request to stack #3179
October 21, 2026 17:28
This was referenced Oct 21, 2026
rwgk
force-pushed
the
rwgk/cb12-on-main-08-runtime-maintenance
branch
2 times, most recently
from
October 21, 2026 19:33
42adc41 to
f9aa1bf
Compare
rwgk
force-pushed
the
rwgk/cb12-on-main-08-runtime-maintenance
branch
2 times, most recently
from
October 22, 2026 04:15
a4c1fe7 to
697e3bd
Compare
Carry forward #2399: retain borrowed setter bytes and release getter-owned storage. Keep this runtime maintenance separate from the build integration. Signed-off-by: Ralf W. Grosse-Kunstleve <rgrossekunst@nvidia.com>
Carry forward #2551 and its regression test. A KeyError inside a registered getter must propagate instead of being reported as an unknown handle type. Signed-off-by: Ralf W. Grosse-Kunstleve <rgrossekunst@nvidia.com>
rwgk
force-pushed
the
rwgk/cb12-on-main-08-runtime-maintenance
branch
from
October 22, 2026 04:26
697e3bd to
7856417
Compare
Contributor
Author
|
/ok to test 7856417 |
Contributor
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Highlights
Separate three CUDA 12 runtime backports from the source/build integration in #3173. Each fix has its own commit; the existing focused regression tests move with the relevant fixes. This keeps the migration review focused while preserving the previously integrated behavior.
Provenance and Review Scope
These changes were already present in the staged #2737 implementation; this PR relocates them without further runtime changes.
KeyErrorpropagatesThe coredump change has no new memory-instrumentation test. Upstream removed an ineffective lifetime regression test; a normal functional round trip would also pass with the getter leak. This extraction preserves that validation boundary.
Runner-specific NVML test maintenance belongs to #3176. The Windows constant declaration remains in #3173 because its Cython warning would otherwise fail the newly enabled warnings-as-errors build.
Stack / Review Boundary
Layer 8 of 8 in native stack #3179, based on #3178. The stack is rebased onto main
dfad7e3658a9. This layer's diff and the complete CUDA 12 source tree are unchanged by the rebase; #3178 records current local checks and earlier integrated QA.Validation
Full hosted CI passes at #3182 for this exact head,
785641713c4d, on its first attempt: all 28 wheel builds, the CUDA 12/CUDA 13 GPU matrix, source-distribution checks, and documentation checks passed. Full hosted CI passes at #3176 for the earlier merge group.At this head, 436 CI-tool tests and 55 subtests pass, together with full local pre-commit. #3178 removes the active legacy backport setting while retaining compatibility with earlier schema-2 tagged registries. #3176 bounds the cuDSS test dependencies to the loader's supported ABI.
pre-commit run --all-files --show-diff-on-failurepasses, including Lychee.Checklist