Release 3.50.4.106, so a new copy is no longer held to 25 KB/s - #237
Merged
Merged
Conversation
versionCode 105 already shipped under the tag v3.50.2.105, so Play would refuse an upload reusing it. 106 is free. The release notes still opened "HTTrack 3.50.2" in all 29 locales and would have gone out as this release's text. Rewritten against the engine delta and this repo's own log, each bullet checked against the tree: - the 25 KB/s cap on a new copy is gone since #234, which is the most visible change here and went unannounced - Retry-After on a 429 or a 503, with the ceiling now settable from Flow control since #236 - the JavaScript module imports the engine now follows - the robots.txt group fix The earlier draft claimed "fewer crashes when memory runs low". That was false and close to inverted: engine d4fc328b replaced a graceful NULL return with assertf() on hts_convertStringIDNAToUTF8, which htsname.c reaches on an ordinary crawl, so low memory now aborts where it used to recover. The clause is dropped rather than reworded. Every locale validates through load_notes() and stays under the 500-character cap, the longest being fr-FR at 486. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <xroche@gmail.com>
The first draft told all 29 locales that a new copy "runs at full speed now". That is false. #234 only dropped the MaxRate=25000 seed, so a new project sends no -A and the engine applies its own ceiling of 100000 bytes per second (htslib.c:6942, enforced in htsback.c). This repo already knew the number, because #234 set the field hint to 100000. A user on a fast link would have measured 100 KB/s and read the release as not shipped. The note now names both numbers. The review also found broken grammar in seven locales and weaker nits in nineteen more, all of them in the subordinate clauses the first draft leaned on. So the English is rewritten as short flat sentences and every locale follows that shape. The longest note drops from 486 characters to 459, which also buys back the fr-FR headroom. A guard in the generator now refuses any locale that does not name the 100 KB/s ceiling, so the claim cannot quietly revert to the vague one. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <xroche@gmail.com>
et and hu-HU wrote "robots.txt reegleid" and "robots.txt szabályokat" with no hyphen, while both hyphenate JavaScript- one bullet earlier and fi-FI already wrote robots.txt-sääntöjä. Both take the hyphen now, so the three compounding locales agree. fi-FI's first bullet had "jopa 100 KB/s" with no case ending. The line is now a predicate nominative, "Uuden kopioinnin raja on nyt 100 KB/s eikä 25 KB/s", which needs none. The Slavic locales are untouched on purpose: they follow robots.txt with a participle rather than compounding, so no hyphen belongs there. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <xroche@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
versionCodegoes to 106 because 105 already shipped under the tagv3.50.2.105, and Play refuses a second upload of the same code.The release notes still opened "HTTrack 3.50.2" in all 29 locales, so they are rewritten for 3.50.4:
Retry-Afteron a 429 or a 503, with the ceiling settable since Let the user cap the wait a server asks for with Retry-After #236Two claims came out. "Fewer crashes when memory runs low" was close to inverted. Engine
d4fc328bswapped a graceful NULL return forassertf(), on a pathhtsname.creaches during any crawl. "Runs at full speed" was wrong too, because the ceiling moved to 100 KB/s rather than away.