Repository navigation
Conversation
Contributor
|
nice, this follows the plan 👍 I know it's blocked on canvas-harness#46, and the NaN/tsc errors on the branch should go away once that's released. some things to sort out in the meantime:
once #46 is out, bump @canvas-harness/* here and I'll do another pass |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Author
|
Addressed the actionable review items in
The package bump is still intentionally pending merge and release of canvas-harness PR #46. Until that release exists, this Dim0 PR should remain a draft; local type-check validation used the built artifacts from #46 without committing vendored output or dependency changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Adds arbitrary text sizing to the board instead of limiting users to S/M/L/XL:
canvas-harnesschange so corner-dragging standalone text scales the font proportionally, similar to ExcalidrawThis addresses #350.
Companion dependency PR: winlp4ever/canvas-harness#46
This PR is intentionally a draft until the companion library change is merged and released, at which point the
@canvas-harness/*dependency can be updated to that release.Related issue
Closes #350
How was it tested?
Checklist
maintype(scope): message)