Conversation
RawDataHandler 1.3.9699.469 drops the last element of every mzML binary data array: each spectrum loses its highest m/z peak and each chromatogram ends with a 0/0 point. 1.3.9769.328 is built from systemsomicslab/msrawdataworkbench#40 (592b6db), which fixes the decoder. Only the Release reference moves. The Debug, vendor-unsupported and MSDIAL 4 references are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pins MsdialCore's Release reference to RawDataHandler 1.3.9769.328. That build has the mzML last-element fix from systemsomicslab/msrawdataworkbench#40 (commit 592b6db).
RawDataHandler 1.3.9699.469 never decodes the last element of an mzML binary data array. For data read from mzML, this means:
Change
One line in
src/MSDIAL5/MsdialCore/MsdialCore.csproj: the ReleasePackageReferenceto RawDataHandler goes from 1.3.9699.469 to 1.3.9769.328. The Debug, vendor-unsupported and MS-DIAL 4 references are unchanged.Must be done before merge
lib/Reifycs/Reifycs.Hive.DataAccess.dllin place ofReifycs.Hive.Reader.dll.Verification
Build. The Console was built from this commit with:
RawDataHandler.dll1.3.9769.328+592b6db.MSDIALCUI.exe --helpand--versionstart, reporting 5.5.260930 and commit f56d447.Reading real mzML.
M3T-Std_neg_DDA_1mz.mzML(2114 spectra) the way MS-DIAL does, withnew RawDataAccess(path, 0, false, false, false).GetMeasurement(). It loadsRawDataHandler.dll,Common.dllandzlib.net.dllfrom one Console output folder at a time.struct).The first five rows:
No MS-DIAL analysis was run for this check.
🤖 Generated with Claude Code
Do not publish the package this build used
RawDataHandler 1.3.9769.328 in the local feed was built without Eazfuscator, which is not installed on the build machine. Two consequences:
RawDataHandler.dll.Before this PR can merge:
The package is also msrawdataworkbench master b34c857 plus the fix, not 1.3.9699.469 plus the fix. It therefore includes the eight RawDataHandlerStandard commits since 1.3.9699.469:
🤖 Generated with Claude Code