Add automatic alignment-only RT correction for LC-MS Console - #810
Merged
Merged
Conversation
added 2 commits
September 26, 2026 01:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.EIC.aeffor non-light Console runs with automatic correction, and make the GUI use the serialized original-RT peak bounds rather than corrected alignment bounds. Include a small tolerance for float-serialized boundary values.Verification
MsdialLcMsApiTestsRelease: 87 passed, 2 skipped.MsdialCoreTestAppTestsRelease: 32 passed.MsdialGuiAppTestsRelease/net48: 74 passed.ce-msms/data: alignment spot 4695 maps sample 9 to detected peak 5564. Its CSS1 EIC contains the original apex at 8.619 min, right boundary at 8.735 min, and trace through 9.295 min. The corrected right boundary is about 8.62 min. This confirms the reported clipping came from mixing corrected peak bounds with original-RT EIC points in an older GUI, not from a short extraction window or failed gap fill.Review notes