Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview:
TROUBLESHOOTING.mdstill tells users that Viper unmarshals throughgithub.com/mitchellh/mapstructure. That repository is archived; Viper replaced it with the fork it maintains,github.com/go-viper/mapstructure/v2(seeUPGRADE.mdand PR #1723). This one-line docs change points the reference at the maintained package.What problem does it solve?:
The troubleshooting page is the first thing users hit when
Unmarshalmisbehaves, and it sends them to dead documentation for the exact tag semantics Viper depends on.viper.go:40importsgithub.com/go-viper/mapstructure/v2andgo.modrequires it directly, so the docs are the only place the old path survives (aside fromUPGRADE.md, where it is intentionally discussed as the old dependency).Special notes for a reviewer:
Docs-only; no code touched. Verified locally:
go build ./...— cleango vet ./...— cleango test -count=1 ./...— all packages pass (viper,internal/encoding/{dotenv,json,toml,yaml})