Repository navigation
Conversation
The only build tags left in the module are viper_bind_struct and viper_finder (internal/features/*.go), and the YAML codec imports go.yaml.in/yaml/v3 unconditionally (internal/encoding/yaml/codec.go:3, go.mod:15), so there is nothing for a user to pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview:
TROUBLESHOOTING.mdtells users to pass aviper_yaml3build tag that does not exist in this module. Reworded the advice so it points at something a user can actually do.What problem does it solve?:
The last line of the "Unquoted 'y' and 'n' characters" section reads:
There is no such tag any more. The only build tags in the module are
viper_bind_structandviper_finder:and YAML v3 is unconditionally the codec Viper uses:
internal/encoding/yaml/codec.go:3—import "go.yaml.in/yaml/v3"(no variant file behind a tag)go.mod:15—go.yaml.in/yaml/v3 v3.0.4So a user following this instruction today adds a tag with no effect and still sees YAML 1.1 boolean resolution. The replacement says the upgrade already happened inside Viper, and points at the two real options: upgrade Viper, or supply a YAML v3 codec through the codec registry (
viper.WithCodecRegistry,viper.Codec).Docs only, one line.
Special notes for a reviewer:
mapstructureimport path in line 5 (## Unmarshaling doesn't work), this one changes line 32 in a different section.gh pr diff 2162confirms the hunks are ~27 lines apart, so the two are independent and either can land first.go build/go test), but the change is markdown text; the cited tag list was produced by searching every//go:buildline in the repo.