Repository navigation
config --list-all: don't list the configured host as a firm - #272
michieldegezelle wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: 3 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. WalkthroughThe change excludes the configured ChangesAuthorized firm listing
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The fix excludes the configured host from firm listings and includes regression coverage; no merge-blocking risk is identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
/review-pr (dry run)Scope: 6 files (1-line prod fix + test + version bump), 1 commit. No existing reviewer comments (CodeRabbit was still running at review time). 5 finders ran (correctness, regression, edgecases, architecture-cli, cli-conventions) — no security/error-handling signal. No fixes needed — correctness, regression, and cli-conventions all came back clean (version bump, CHANGELOG format, and test verified correct). Deliberately deferred (1 Suggestion, raised independently by 2 finders — architecture-cli and edgecases): 752/752 tests pass, lint clean. |
…dfirms-host-filter Resolves the CHANGELOG.md/package.json/package-lock.json conflict from main's own 1.60.0 version bump (update-text-properties, merged after this PR was opened). Rebumps this PR's entry to 1.60.1. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Summary
listAuthorizedFirms()filtereddefaultFirmIDsandpartnerCredentialsout of the firm list but nothost, soconfig --list-allprints["host", undefined]alongside real firms on every perfectly valid config.hostto the filter.Unrelated to credential-file corruption handling - split out of a larger parked branch (see #270, #271) as its own small, real bug fix.
Test plan
does not list the host key as a firm), watched it fail against current code, confirmed the fix turns it greennpm test- 752/752 passnpm run lint- clean