Repository navigation
[CodeQuality] Skip constant expression in repeated compare to in_array rules - #8651
Merged
Merged
Conversation
…tor and RepeatedAndNotEqualToNotInArrayRector
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#9930
in_array()is a function call, which PHP forbids in a constant expression (property default value, class constant value, param default). Rewriting repeated===/!==compares intoin_array()there produces a fatal error.Both
RepeatedOrEqualToInArrayRectorandRepeatedAndNotEqualToNotInArrayRectornow bail out when the node sits in a constant expression (IS_DEFAULT_PROPERTY_VALUE,IS_CLASS_CONST_VALUE,IS_PARAM_DEFAULT).