Repository navigation
Add textIndopakNastaleeq to Quran core word records - #89
Merged
Merged
Conversation
Type the new nullable `text_indopak_nastaleeq` Content Sync field on `QuranCoreWordSnapshotRecord` and deprecate `textIndopak`, which is retained for backwards compatibility. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
size-limit report 📦
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2523c8f6cb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Snapshots generated before the server-side backfill omit the field, so declaring it required overstated the runtime contract and broke consumers that construct QuranCoreWordSnapshotRecord values. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refresh from the current qf-api-docs OpenAPI specs, which added reading-bookmarks, share-verse image, and post reaction operations. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
textIndopakNastaleeq?: string | nulltoQuranCoreWordSnapshotRecord(Content Syncquran_core:1word records), alongsidetextIndopak. It is optional because snapshots generated before the server-side backfill do not include it.textIndopakas@deprecated(usetextIndopakNastaleeq). The old field is retained, so this is additive and non-breaking.record.textIndopakNastaleeq ?? record.textIndopakand notes the deprecation and that the new field may be absent.findSnapshot()quran_core test assertstext_indopak_nastaleeqis camel-cased totextIndopakNastaleeq(existinghumpsconversion, no code change needed) and that a legacy word record has no such property.@quranjs/api.chore: regenerate operation catalogs. The "📚 Operation Catalogs" CI check compares against live qf-api-docs OpenAPI, which gained reading-bookmarks, share-verse image and post reaction operations since the last refresh. Regenerated in a separate commit; no changeset, following prior catalog refresh commits (e.g. ee7414b, 43204f5).Dependency
Depends on the server-side
quran_coreword fieldtext_indopak_nastaleeqbeing deployed (parallel tools.quran.com / quran.com-api changes). Until then the value is absent at runtime (hence optional);textIndopakis still served.Verification
pnpm lint: passpnpm --filter @quranjs/api check:operation-catalogs: up to datetsc --noEmiton touched files: no errors (repo has no typecheck script for this package; the full-project run has pre-existing errors unrelated to this change)Resources.tsandresources.test.tsas unformatted onorigin/maintoo (pre-existing)🤖 Generated with Claude Code