Repository navigation
Add textImlaei to Quran core word records - #92
Merged
Merged
Conversation
Type the new nullable `text_imlaei` Content Sync field on `QuranCoreWordSnapshotRecord`. It is optional because snapshots generated before the server-side backfill omit it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
textImlaei?: string | nulltoQuranCoreWordSnapshotRecord(Content Syncquran_core:1word records). It is optional because snapshots generated before the server-side backfill do not include it.record.textImlaei.findSnapshot()quran_core test assertstext_imlaeiis camel-cased totextImlaei(existinghumpsconversion, no code change needed) and that a legacy word record has no such property.@quranjs/api.Follows the same pattern as #89 (
textIndopakNastaleeq).Dependency
Depends on the server-side
quran_coreword fieldtext_imlaeibeing deployed (parallel tools.quran.com / quran.com-api changes). Until then the value is absent at runtime (hence optional).Verification
pnpm --filter @quranjs/api check:operation-catalogs: up to datetest:package(build + App State smoke): passtsc --noEmit -p packages/api: no errors in touched files (the package has no typecheck script; the full-project run has pre-existing errors unrelated to this change)Resources.tsandresources.test.tsas unformatted onorigin/maintoo (pre-existing)🤖 Generated with Claude Code