Repository navigation
fix: treat an empty index.db-wal as missing in the store fingerprint - #79
shahmir-oscilar wants to merge 1 commit into
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📜 Recent review details
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
|
@zkochan Could you take a look when you get a chance? Thank you so much! |
Closes #78.
In jobs without a container, the store has an empty
index.db-walwhenfingerprintRestoredStoreruns. The project install opens and closes the database, SQLite deletes the empty log, and the post step's fingerprint no longer matches, so the store is saved again on every run.fingerprintStorenow treats a 0-byteindex.db-walas missing. A non-empty log still changes the fingerprint, and a checkpoint that copies pages intoindex.dbstill changes its size or mtime.Validation:
New test: an empty write-ahead log has the same fingerprint as none. It fails without the change. All 104 tests and the TypeScript check pass.
dist/index.jsrebuilt withpnpm run build; rebuildingmainwithout the change reproduces the committed bundle byte for byte, so the bundle diff comes only from this change.End to end in shahmir-oscilar/pnpm-setup-store-skip-repro. Its
empty-wal-fingerprintbranch runs every job on this commit;mainruns v3.1.1. Same push of both:runner-check(no container)Cache saved with the key: …The store has not changed since it was restored, not saving cache.container-checkThe store has not changed …The store has not changed …runner-split-check(no container, install as its own step)Cache saved with the key: …The store has not changed …Drafted by Claude Code
Summary by CodeRabbit