Live-тесты: реальные проверки прав процессоров - #699
Merged
Conversation
Force SESSION_STATE_INITIALIZED so checkPolicy runs under PHPUnit CLI, and cover Product/Multiple deny as a canary for missing $permission.
This was referenced Sep 12, 2026
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
В live-сьюте на testbench проверки
$permissionне работали: в CLIgetSessionState()даётSESSION_STATE_UNAVAILABLE, иcheckPolicy()всегда возвращаетtrue. Deny-тесты вечно пропускались.Добавлен
withProcessorPoliciesEnforced(): на время callback форсируетсяSESSION_STATE_INITIALIZED, затем состояние восстанавливается. Deny-тесты GetList/Status Create реально выполняются. Добавлен canary наProduct/Multiple(msproduct_save). Сообщение отказа сверяется с лексикономpermission_denied_processor.Тип изменений
Связанные Issues
Closes #696
Как это было протестировано?
Canary вручную: пустой
$permissionуProduct/Multiple→ProductProcessorAclTestпадает. После возврата$permission = 'msproduct_save'— зелёный.Полный
composer ci:php/ vue lint / stan в этом PR не гонялись (только live Modx ACL-слой). Ожидается зелёный job live MODX в CI.composer ci:php/composer test,npm run lint:ci,composer stan/ GitHub Actions CI)Конфигурация тестирования:
fix/issue-696-processor-acl-sessionСкриншоты (если применимо)
Чеклист
composer stan/ CI jobPHPStan)npm run lint:ciдля Vue)Дополнительные заметки
tests/Modx/*и README сьюта.ExtraFieldMapTest::tearDownчистит map/cache после merge extra fields (изоляция от последующих тестов наmsVendor).modxkit/testbench, покрытие Sort отдельно (canary — Multiple).