Live-тесты: убрать проверки MODX/testbench вместо MiniShop3 - #700
Open
Ibochkarev wants to merge 1 commit into
Open
Live-тесты: убрать проверки MODX/testbench вместо MiniShop3#700Ibochkarev wants to merge 1 commit into
Ibochkarev wants to merge 1 commit into
Conversation
Keep only MiniShop3-backed checks: phinx.php vs live dbname, processors, models, DI, events. Leave the processors_path warning in the suite README.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
Часть live-тестов в
tests/Modx/не могла покраснеть из-за поломки MiniShop3: они проверяли подготовку testbench, ядро MODX или дублировали соседние кейсы.Удалены hollow-тесты и дубли. Оставлен
phinx.phpvs live$modxdbname (PhinxConfigLiveTest). Предупреждение про строковый action безprocessors_pathосталось в README.Тип изменений
Связанные Issues
Closes #697
Как это было протестировано?
Локально
ModelPersistTestкрасный на загрязнённой БД (msProductField/ schema drift от Phinx). К #697 не относится. Полныйcomposer test:modxожидается в CI.composer ci:php/composer test,npm run lint:ci,composer stan/ GitHub Actions CI)Конфигурация тестирования:
test/issue-697-drop-hollow-live-testsСкриншоты (если применимо)
Чеклист
composer stan/ CI jobPHPStan)npm run lint:ciдля Vue)Дополнительные заметки
Удалено:
SchemaTablesTest(тавтологияSHOW TABLESvsPackageModels::tables(); схема из миграций — Live-тесты: схема из Phinx-миграций вместо карты xPDO #695)MsOrderPersistTest(дубльModelPersistTest)TokenNameSettingTest(MODX helpers / дубльServiceRegistryLiveTest)StatusCreateProcessorTest::testStringActionWithoutProcessorsPathIsNotFound(поведение ядра, warning в README)Оставлено:
PhinxConfigLiveTest($modx = $this->modxобязателен передrequire phinx.php).