Repository navigation
Conversation
|
@LukeLongworth would you be willing to review and comment on this please? If you don't have time, just let me know and I'll take a look myself. Thanks @adamant-pwn much appreciated. |
|
Kia ora @sangwinc and @adamant-pwn, this is all very sensible. I'll freely admit that I'm not very familiar with software engineering, so I'll trust that all the files are in the right place and are working correctly in their new homes. The descriptions provided in the documentation are clear and correct to my memory, and they accurately describe the purpose of these functions. I can provide more examples of their applications if desired. Notably, I acknowledge that this is intended to be a pilot programme, but I would support the inclusion of Sorry for the delay on this review Chris, I try to keep an eye on these but the notifications come through to my personal email rather than my work email so they sometimes get missed. A direct prompt from you is a good idea if something is important! |
|
Thanks Luke! I've added the SVD motivation to The follow-up is stacked on this PR so the changes can be reviewed incrementally. @sangwinc, would you prefer to keep it separate or fold it into this PR? The implementation is ready either way. |
The five shape predicates are missing from the generated CAS reference. Move
col_vecp,row_vecp,vectorp,squarep, anddiagpintomaximasrc/linearalgebra/predicates, preserving their implementations and attribution. Document vector notation, empty and rectangular shapes, and simplification behaviour; retain links from the existing topic reference. Thediagpdocumentation now includes Luke's SVD motivation.Migrate 23 existing cases and add 29, each run with both simplification modes. Runtime code, tests, and documentation are generated with the official compiler.
Validation: 256/256 generated CAS executions pass on Maxima 5.45.1/ECL. The original migration also passed 140/140 before/after comparisons and six vector-input tests (34 assertions). Its legacy core runner had the same 15 unrelated failures before and after; no fully passing legacy suite is claimed. CI is rerunning for the documentation update.
Closes #1880.