Repository navigation
smite-scenarios: give each mock transaction its own block position - #287
Merged
Merged
Conversation
NishantBansal2003
approved these changes
Oct 16, 2026
NishantBansal2003
left a comment
NishantBansal2003
left a comment
Member
There was a problem hiding this comment.
Thanks! This was on my todo for the follow-up PR with more checks for channel_ready
LGTM!
For the existing tests this doesn't matter, but as we start adding more SCID checks to the channel_ready oracle we'll need to ensure that we aren't sharing SCIDs between channels.
morehouse
force-pushed
the
mock_distinct_block_positions
branch
from
October 16, 2026 21:46
d98e5bd to
e544db6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the existing tests this doesn't matter, but as we start adding more SCID checks to the
channel_readyoracle we'll need to ensure that we aren't sharing SCIDs between channels.Noticed this while reviewing #260.