Repository navigation
smite-scenarios: name or derive test constants - #288
Merged
Merged
Conversation
morehouse
added this pull request to stack #289
October 15, 2026 21:51
NishantBansal2003
approved these changes
Oct 16, 2026
NishantBansal2003
left a comment
NishantBansal2003
left a comment
Member
There was a problem hiding this comment.
LGTM! Needs a rebase on top of #287
erickcestari
approved these changes
Oct 16, 2026
erickcestari
left a comment
erickcestari
left a comment
Member
There was a problem hiding this comment.
LGTM! The nit is not relevant. Feel free to merge as it's if you prefer.
Comment on lines
+584
to
+586
| for id in [TEMPORARY_CHANNEL_ID, SECOND_TEMPORARY_CHANNEL_ID] { | ||
| assert!(fx.negotiation(&id).accept_channel.is_some()); | ||
| } |
Member
There was a problem hiding this comment.
nit:
Suggested change
| for id in [TEMPORARY_CHANNEL_ID, SECOND_TEMPORARY_CHANNEL_ID] { | |
| assert!(fx.negotiation(&id).accept_channel.is_some()); | |
| } | |
| for id in [TEMPORARY_CHANNEL_ID, SECOND_TEMPORARY_CHANNEL_ID] { | |
| assert!(fx.negotiation(&id).accept_channel.is_some(), "no accept_channel recorded for {id}"); | |
| } |
morehouse
force-pushed
the
name_and_derive_constants
branch
from
October 16, 2026 21:06
8ab3ab2 to
48c5797
Compare
Name the temporary channel IDs used in the sample negotiations and the SCID used in funding tests.
morehouse
force-pushed
the
name_and_derive_constants
branch
from
October 16, 2026 21:15
48c5797 to
1359f1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eliminates a few unnecessary magic constants.
Depends on #286.