Repository navigation
fix: isolate lenient rule bootstrap failures - #218
Merged
swedishborgie merged 3 commits intoSep 23, 2026
Merged
swedishborgie merged 3 commits into
swedishborgie merged 3 commits into
Conversation
r4ravi2008
force-pushed
the
review/lenient-bootstrap-failure-isolation
branch
from
September 23, 2026 00:10
332e883 to
8fe4848
Compare
Bootstrap ran inside the directory walk, so one failed script aborted the rest of that directory. Discover and expand a directory first, then run its bootstraps. On a lenient path, skip only the failing rule.
Describe the discover-then-bootstrap order and how strict vs lenient search paths treat bootstrap and parse failures.
r4ravi2008
force-pushed
the
review/lenient-bootstrap-failure-isolation
branch
from
September 23, 2026 00:10
8fe4848 to
f9319b0
Compare
Stop wrapping the same find-and-execute message twice so callers can match the rule file without reading error text.
swedishborgie
approved these changes
Sep 23, 2026
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rule bootstrap scripts used to run inside the directory walk. A non-zero exit aborted
filepath.Walk, so later rule files in that directory were never discovered. On a lenient search path this became a single "skipping directory" warning and the remaining rules were dropped with no per-file signal.This change discovers and expands one rule directory first, then runs that directory's bootstrap scripts. Bootstrap for a directory finishes before the next directory is discovered, so search-path order is unchanged.
Changes
pkg/codingcontext/context.go: split discovery (discoverPendingRule) from bootstrap/publication (bootstrapAndPublishRules).docs/reference/search-paths.md: document the new failure handling.Testing
go test -race -count=1 ./pkg/codingcontext/context_bootstrap_isolation_test.go:Line Changes
pkg/codingcontext)Definition of Done