Repository navigation
fix: isolate lenient rule discovery failures - #219
Open
r4ravi2008 wants to merge 1 commit into
Open
r4ravi2008 wants to merge 1 commit into
r4ravi2008 wants to merge 1 commit into
Conversation
A parse or expand error on a lenient path used to stop the directory walk. Continue past the failing file so later sibling rules are still discovered.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A parse or expansion error on a lenient search path still stopped the rest of that rule directory's walk. Later sibling rules were never discovered, even after bootstrap isolation in #218.
This change treats a lenient parse or expansion failure the same way as a lenient bootstrap failure: warn, skip only the failing file, and keep walking.
Changes
pkg/codingcontext/context.go: on a lenient path,discoverPendingRuleerrors logskipping rule file after discovery failureand returnnilfrom the walk callback.docs/reference/search-paths.md: lenient parse, expand, and bootstrap failures all skip only the failing rule.Testing
go test -race -count=1 ./pkg/codingcontext/TestRun_LenientRuleParseFailurePreservesEarlierRulesTestRun_LenientRuleParseFailureDoesNotBlockLaterLenientSearchPathLine Changes
pkg/codingcontext)Definition of Done