Skip to content

fix(release): re-enable the winget release job #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
soustruh merged 1 commit into from
Sep 21, 2026
Merged

fix(release): re-enable the winget release job #763

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 11 additions & 16 deletions .github/workflows/release-kbagent.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,29 +619,24 @@ jobs:

# ── WinGet: submit a PR to microsoft/winget-pkgs via wingetcreate.
#
# DISABLED (if: false): `wingetcreate update` fails on every tag because the
# `Keboola.KeboolaCLI2` package has never had its FIRST submission to
# microsoft/winget-pkgs -- there is no manifest to update, so the job has been
# red on every release since it was added, masking real failures. Re-enable by
# restoring the original condition (kept below) AFTER the bootstrap submission
# lands; see the NOTE in the first step for what that submission must contain.
# The one-time bootstrap `wingetcreate submit` this job used to be blocked on
# has already happened by hand: `Keboola.KeboolaCLI2` has a manifest on
# microsoft/winget-pkgs starting at 0.79.0 (winget-pkgs PR #409446). That
# manifest is what `wingetcreate update` below now bumps on every release.
winget:
needs: [version, chocolatey, publish-s3]
# Original condition, restore when re-enabling:
# needs.version.outputs.IS_PRERELEASE == 'false' && startsWith(github.ref, 'refs/tags/')
if: false
if: needs.version.outputs.IS_PRERELEASE == 'false' && startsWith(github.ref, 'refs/tags/')
runs-on: windows-latest
environment: release
env:
VERSION: ${{ needs.version.outputs.VERSION }}
steps:
# NOTE for whoever gets this job working: `wingetcreate update` only bumps
# the version and installer URL -- it does NOT write locale fields. The
# FIRST successful submission must therefore set `License: Apache-2.0`
# itself, because every later run inherits whatever that manifest said.
# Do not copy the existing `Keboola.KeboolaCLI` manifest: that is the
# legacy Go CLI from keboola/keboola-as-code, a different product under a
# different (MIT) licence. `Keboola.KeboolaCLI2` has never been submitted.
# `wingetcreate update` only bumps the version and installer URL -- it
# does NOT write locale fields, so it depends on the bootstrap manifest
# (see above) already having set them, e.g. `License: Apache-2.0`. Do
# not confuse this with `Keboola.KeboolaCLI`: that is the legacy Go CLI
# from keboola/keboola-as-code, a different product under a different
# (MIT) licence.
- name: Submit to winget-pkgs
shell: bash
env:
Expand Down