Skip to content

fix(release): re-enable the winget release job - #763

Merged
soustruh merged 1 commit into
mainfrom
martinvasko-enable-winget-release-job
Sep 21, 2026
Merged

soustruh merged 1 commit into
mainfrom
martinvasko-enable-winget-release-job

Conversation

@Matovidlo

Copy link
Copy Markdown
Contributor

Summary

  • Re-enables the winget job in .github/workflows/release-kbagent.yml, restoring its original trigger condition (needs.version.outputs.IS_PRERELEASE == 'false' && startsWith(github.ref, 'refs/tags/')) in place of the hardcoded if: false.
  • Updates the job's comments, which had gone stale: they claimed Keboola.KeboolaCLI2 had "never had its first submission" to microsoft/winget-pkgs, blocking wingetcreate update from having anything to bump.
  • That's no longer true — the one-time bootstrap wingetcreate submit was already done by hand on 2026-09-07 (microsoft/winget-pkgs PR #409446), creating the Keboola.KeboolaCLI2 manifest starting at version 0.79.0. Nobody flipped the job back on afterward, so every release since (up through the current 0.93.2) has silently skipped winget publishing even though the blocker was gone.
  • WINGET_TOKEN is already present as a release-environment secret (set 2026-06-15), so no secret changes are needed here.

Test plan

  • Workflow-only change; no application code paths affected.
  • Verified via the GitHub API that the Keboola.KeboolaCLI2 manifest exists on microsoft/winget-pkgs@master (manifests/k/Keboola/KeboolaCLI2/0.79.0) and that WINGET_TOKEN is set in this repo's release environment.
  • Can't fully dry-run the winget job locally (it publishes to an external repo and only runs on a real version tag); the real verification is watching the job on the next tagged release and confirming a new microsoft/winget-pkgs PR opens with the correct version/URL/hash.

Related

@keboola-pr-reviewer-bot keboola-pr-reviewer-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: needs_human (risk 4/5) · profile _default

Head commit has failing checks (check, test (3.12)); no required-check rules discovered on the base branch, falling back to block-on-any-failure.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Remove the Chocolatey gating risk and update the now-stale README guidance.

Pull request overview

Re-enables automated WinGet publishing for stable tagged releases now that the package manifest exists.

Changes:

  • Restores the stable-tag condition for the winget job.
  • Updates comments documenting the completed bootstrap manifest.
  • Uses the existing WINGET_TOKEN secret.
File summaries
File Summary Findings
.github/workflows/release-kbagent.yml Re-enables and documents WinGet release publishing. Moderate (1 vote): Chocolatey remains a transitive dependency and can prevent WinGet publishing. Nit (1 vote): Update README.md package-manager guidance.
Review details

Suppressed comments (2)

.github/workflows/release-kbagent.yml:625

  • Once this job is re-enabled, README.md:53 still tells users that no WinGet package exists or has been submitted. That will become incorrect after the next tagged release, so please update the current package-manager guidance alongside this workflow (historical changelog notes can remain historical).
  # The one-time bootstrap `wingetcreate submit` this job used to be blocked on
  # has already happened by hand: `Keboola.KeboolaCLI2` has a manifest on
  # microsoft/winget-pkgs starting at 0.79.0 (winget-pkgs PR #409446). That
  # manifest is what `wingetcreate update` below now bumps on every release.

.github/workflows/release-kbagent.yml:628

  • Now that this condition activates the job, it is still transitively gated by chocolatey through needs; a Chocolatey publish failure (or duplicate-version rerun) makes GitHub skip WinGet even though WinGet only consumes the S3 ZIP produced by publish-s3. That can silently miss the WinGet PR, so remove chocolatey from this dependency (or explicitly handle its failure with always()).
    needs: [version, chocolatey, publish-s3]
    if: needs.version.outputs.IS_PRERELEASE == 'false' && startsWith(github.ref, 'refs/tags/')
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

The wingetcreate bootstrap submission this job was waiting on has already
happened by hand (Keboola.KeboolaCLI2 0.79.0 manifest merged into
microsoft/winget-pkgs on 2026-09-07, PR #409446), so `wingetcreate update`
now has an existing manifest to bump. Restore the real trigger condition
so future tagged releases publish to winget again instead of silently
skipping it.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@Matovidlo
Matovidlo force-pushed the martinvasko-enable-winget-release-job branch from defe8e6 to 009dbda Compare September 16, 2026 06:02

@soustruh soustruh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Minimal, scoped fix that re-enables the winget release job. CI is green.

@soustruh
soustruh merged commit a87157a into main Sep 21, 2026
3 checks passed
@soustruh
soustruh deleted the martinvasko-enable-winget-release-job branch September 21, 2026 15:14
@soustruh soustruh mentioned this pull request Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants