ensure shearing box test also analyse B - #412
Merged
Merged
Conversation
Merged
glesur
added a commit
that referenced
this pull request
Sep 24, 2026
### Changed - bump up Kokkos to 5.1. As a result, Idefix now requires a C++20-compatible compiler (#384) - improve Kokkos 5 performances on AMD targets (#402) - make MPI gpu-direct optional with a device-host fallback transfer path (#389) - refactor communication packing/unpacking in Axis and ConstrainedTransport using Buffer and BoundingBox (#385) - move CheckNan to the end of loop stages in TimeIntegrator (#403) - keep inter-cell flux in every direction for analysis (#337) - update CI/tooling and dependencies (#371,#372,#377,#383,#390,#392,#393,#400) - update copyright headers across the project (#410) ### Fixed - fix div(B) check robustness (#369) - fix segfault when using UCT_HLL with DIMENSIONS < 3 (#386) - fix coarsening + viscosity CFL condition violation (#397) - fix issues when linking parallel HDF5 with CMake (#391) - restore Ctrl-C handling when pydefix is active (#388) - ensure shearing-box tests also analyse magnetic field B (#412) - fix security settings in CI jobs (#373) ### Added - enable parsing of 1D column data and interpolation in functional space using `LookupTable` (#401) - add conservation tests to OT and OT3D (#407) - add/improve `testme.json` validation in tests (#378, #394, #405) - add documentation for pydefix usage in virtual environments (#365) - add compiler informations in the logs and in stdout (#402) --------- Co-authored-by: Victor Réville <victorreville@gmail.com> Co-authored-by: Hal Bal <vreville@irap.omp.eu> Co-authored-by: Jean Kempf <jean.kempf@irap.omp.eu> Co-authored-by: Victor Réville <47865059+vreville@users.noreply.github.com> Co-authored-by: Marc Coiffier <marc.coiffier@univ-grenoble-alpes.fr> Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com> Co-authored-by: Clément Robert <cr52@protonmail.com> Co-authored-by: glesur <glesur@login6.head.adastra.cines.fr> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Alankar Dutta <dutta.alankar@gmail.com> Co-authored-by: Sébastien Valat <sebastien.valat.dev@orange.fr> Co-authored-by: Sébastien Valat <sebastien.valat@univ-grenoble-alpes.fr> Co-authored-by: nscepi <63753204+nscepi@users.noreply.github.com> Co-authored-by: ScatteredComet <120208759+ScatteredComet@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
ShwaveAmplitudeanalysis in the shearing box MHD test to add support for an optional phase shift parameter and applies a phase shift to the analysis of magnetic field components as the B field is expected to be shifted