Conversation
…lay which slope limiter is used, fixed typo in the braginskii doc
updated ShowConfig functions from braginskii tc and viscosity to disp…
update changelog and version in develop
checking that everything works as expected)
* fix the computation of velocity gradients in the viscosity module when coarsening is enabled.
… ./test.py (#399) * test: Fix missing protagation of return status when calling pytest in ./test.py * fix: fix an issue coming from the previous refactoring about accessing a GPU buffer on CPU * fix: Fix some warnings about unused variabled blocking the test suite * test: fix utils/lookupTable test by adding possibility to call a python function from testme.json * fix: communication issue introduced during the comm refactoring in recent commit of PR #385. * fix: add missing new file testmelib.py in test/utils/lookupTable
* Fix parallel HDF5 detection when found via CMake config package find_package(HDF5) can resolve through the HDF5-provided CMake config package (config mode), which does not set HDF5_IS_PARALLEL. The previous 'if(NOT HDF5_IS_PARALLEL)' check then wrongly failed for a genuinely parallel HDF5 build. Detect parallel support robustly: prefer imported targets (hdf5::hdf5 / HDF5::HDF5), fall back to the FindHDF5 module, and determine parallelism from HDF5_IS_PARALLEL/HDF5_C_IS_PARALLEL, 'h5cc -showconfig', or an H5Pset_fapl_mpio compile+link probe. * Silence unused-variable warnings with [[maybe_unused]] Mark variables that are unused in some build configurations as [[maybe_unused]]: the MPI buffer index locals in Axis::ExchangeMPI and tot_dim in the DIMENSIONS==2 branch of Xdmf::Write. * Apply suggestions from code review Minor Co-pilot suggested fixes Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Minor typo fix * [ENH] refactor of parallel hdf5 detection --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: Sébastien Valat <sebastien.valat@univ-grenoble-alpes.fr>
…bout nodejs-20 instead of nodejs-24. (#400)
- Constrain Kokkos parallel_for range kernels via LaunchBounds<256> in idefix_for wrappers to mitigate AMD register spilling. - Replace the generated-in-source version.hpp mechanism with CMake-generated headers (version.h, compiler_info.h) and update outputs/version printing to use them. - Add Idefix_SUPPRESS_FMA and a SuppressFMA.cmake helper to disable FMA contraction across toolchains; update the Python test harness to enable it for bitwise-stable comparisons. --------- Co-authored-by: Geoffroy Lesur <geoffroy.lesur@univ-grenoble-alpes.fr> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…ce-host explicit transfers (#389) * gpu-direct: handle communications when MPI GPU DIRECT is not there/available. --------- Co-authored-by: Geoffroy Lesur <geoffroy.lesur@univ-grenoble-alpes.fr>
* doc: fix typo in test runner documentation (tests => test) * test: fix issue when generating the .junit.xml report (the output stream is not there for failed tests).
…e using `LookupTable` object (#401) * Allow 1D lookup tables to be read as columns of a CSV file * LookupTable interpolation on function space * Add accessors to the neighbours used by the LookupTable interpolation * Cache the neighbour search between Get and the neighbour getters * generate irregular grid to test the lookupTable generic neighbour search * Use a dichotomy instead of linear search for faster lookup search in large tables * added test helpers for clarity. Should be replaced by proper unit test library (note in this PR though) --------- Co-authored-by: Geoffroy Lesur <geoffroy.lesur@univ-grenoble-alpes.fr>
* add documentation for pydefix in virtualenv
* TST/DEP: update minimal Python requirements * TST: require inifile to be Pluto/Idefix valid --------- Co-authored-by: Geoffroy Lesur <geoffroy.lesur@univ-grenoble-alpes.fr>
…ore understandable errors. (#405) * test: add usage of jsonschema to validate the testme.json file and get more understandable errors. * test: add testme.json format validation in the pre-commit + improve the error messages of test.py + make it faster to start.
* Move CheckNan to end of loop on stages in timeIntegrator
CheckNan was previously located after EvolveStage. However, EvolveStage
updates the conservative variables and CheckNan checks the primitive
variables. This reports the detection of a NaN to the next cycle. By
moving CheckNan to the end of the loop on stages in timeIntegrator,
so after the ConsToPrim, this PR ensures that we detect the NaN at
the right cycle.
* [pre-commit.ci lite] apply automatic fixes
* Move CheckNan at end of integration cycle
* Update pre-commit config
---------
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
* check conserved quantities
* keep Flux array in each direction (increase memory footprint, but easier post-treatment)
* ensure shearing box test also analyse B * add B field in the validation of the shearing box test. Adjust tolerance accordingly.
header: introduce a script to update the source file headers with licence & authors (imported from MALT : MALloc Tracker)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed
Fixed
Added
LookupTable(Enable parsing of 1D column data and interpolation in functional space usingLookupTableobject #401)testme.jsonvalidation in tests (test: add "default" semantic to testme.json files #378, TST: require inifile to be Pluto/Idefix valid #394, test: add usage of jsonschema to validate the testme.json file and get more understandable errors. #405)