feat(eightsaf-extension): add EightSaf wallet adapter for Interchain Kit - #44
Conversation
Add @interchain-kit/eightsaf-extension so dApps can connect to window.eightsaf via ExtensionWallet and CosmosWallet for Safrochain connect, sign, and broadcast flows.
Register @interchain-kit/eightsaf-extension in the pnpm workspace lockfile.
Replace the placeholder hexagon icon with the real SVG from eightsaf/public/eightsaf-icon.svg.
There was a problem hiding this comment.
LGTM — thanks for adding 8SAF, and sorry it sat unreviewed for so long. The package follows the existing extension-adapter layout (ExtensionWallet + CosmosWallet wired via setNetworkWallet, registry with windowKey/cosmosKey/walletIdentifyKey/keystoreChange, publishConfig.directory: dist, workspace:* dep on core), matching e.g. wallets/ninji-extension.
Verified on a local merge onto current main: pnpm install --frozen-lockfile accepts the updated lockfile (it adds the wallets/eightsaf-extension importer; the rest of the lockfile diff is pnpm re-serialization), pnpm build and pnpm test pass (incl. the new package's test), and eslint src __tests__ in the new package is clean. Also confirmed it merges cleanly together with #39, #42 and #45. With lerna version --conventional-commits the package would be published as @interchain-kit/eightsaf-extension@0.11.0.
Optional follow-up: examples/react lists the other wallets in src/main.tsx; adding 8SAF there would make it easy to try in the demo app.
Reviewed by Devin on behalf of @pyramation
Summary
@interchain-kit/eightsaf-extensionfor EightSaf browser extension supportwindow.eightsafthroughExtensionWalletandCosmosWalletChanges
wallets/eightsaf-extensionTest plan
pnpm --filter @interchain-kit/core buildpnpm --filter @interchain-kit/eightsaf-extension testpnpm --filter @interchain-kit/eightsaf-extension buildeightsafWallettoChainProvidersafrochain-1orsafrochain-testnet-1)Notes