feat: land community PRs #39, #44, #45; CI on Node 22 - #47
Merged
Merged
Conversation
Add @interchain-kit/eightsaf-extension so dApps can connect to window.eightsaf via ExtensionWallet and CosmosWallet for Safrochain connect, sign, and broadcast flows.
Register @interchain-kit/eightsaf-extension in the pnpm workspace lockfile.
Replace the placeholder hexagon icon with the real SVG from eightsaf/public/eightsaf-icon.svg.
Regenerates pnpm-lock.yaml with pnpm 9.15.4 (CI's version) for the eightsaf-extension importer and @types/node 22.
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Merges the three open community PRs as-is (their branches are merged with
--no-ff, so authorship is kept and GitHub will mark #39/#44/#45 merged when this lands), plus a CI toolchain bump.signingRequestExpiryto WC signing requests #39 –signingRequestExpiry(@drimchansky):new WCWallet(info?, wcOptions?, { signingRequestExpiry })→ passed as the 3rd arg ofUniversalProvider.request(args, chain, expiry)on every WC sign call (cosmos amino/direct, eth, solana). Opt-in;undefinedkeeps WalletConnect's default. Still relevant:wc-wallets/*on main has no expiry plumbing. Merges cleanly over fix: validate WC session covers all chains before reuse #43's multichain session changes. Addedpackages/core/__tests__/wc-wallet-expiry.test.ts(WCWallet + WCCosmosWallet passthrough, unset →undefined).Uint8Arraypubkeys (@Steve0x2a):LocalStorage.load()turns JSON-mangled{0:…,1:…}pubkeys back intoUint8Array. Still relevant: on mainWalletManagerStore.restore()loads the cached account unchanged, so signing after a reload fails with "length of pubkey is incorrect" (Uint8Arraypubkeys degrade to plain objects afterlocalStorageround-trip #40).@interchain-kit/eightsaf-extension(@Mechack08): new extension adapter for EightSaf (Safrochain wallet), same shape as the other extension wallets (ExtensionWallet+CosmosWallet,window.eightsaf). No runtime deps beyond@interchain-kit/core.20→22;actions/checkout,actions/setup-node,pnpm/action-setupv4 → v5 andupload-artifactv4 → v6 (allnode24runtimes, which removes the "Node.js 20 is deprecated" warning). Rootengines.node>=22.0.0,@types/node^22.Lockfile
#44's lockfile commit is superseded:
pnpm-lock.yamlis regenerated from main's lockfile with CI's pnpm 9.15.4. The large line count is formatting only (main's lockfile has expandedresolution: { integrity }blocks; pnpm writes them inline). Same 2119 packages before/after; the only content changes are the newwallets/eightsaf-extensionimporter,@types/node20.19 → 22.19, and peer-suffix keys. No new registries, tarball or git sources.Security review
prepack: npm run build, and no new third-party deps, network calls, CI edits, oreval/obfuscation.<path>/<style>(no<script>, event handlers,href, orforeignObject).Verification (local, Node 22.23 / pnpm 9.15.4)
pnpm install --frozen-lockfile✓pnpm run build✓ — same TS diagnostics as main's CI (vue, mock-wallet, metamask wallets); none come from changed filespnpm run test✓ (core 128, store 177, all wallets incl. eightsaf)Link to Devin session: https://app.devin.ai/sessions/a02c84f654b94cbcb50936e98373fba5
Open in Devin Desktop: https://app.devin.ai/desktop/session/a02c84f654b94cbcb50936e98373fba5?variant=devin
Requested by: @pyramation