Repository navigation
test(rung10): the python test-suite port - the parity bar - #118
Merged
Merged
Conversation
… files The fakes python's tests built by patching execute_query/wmill become gateway-trait injection (FakeDb/FakeWindmill/FakeCausal, tests/rust). Ported so far: wish assignment upsert, instruments read, seek return mirror, watermark slots. The parity bar already earned its keep - three gaps in the first rust body, cured against the python reference: - read_state_verdict missed the rung-9 instruments column (rollout- order guard, message-matched fallback, torn-payload tolerance) - read_seek_return and get_wish's seek-return mirror were absent - get_systemtender dropped instruments from the GET envelope and swallowed verdict errors where python fails the read Co-authored-by: cherusk <10729954+cherusk@users.noreply.github.com>
…handle for assertions Co-authored-by: cherusk <10729954+cherusk@users.noreply.github.com>
…the ask call hands the array view The door test and the grammar module existed only as untracked files in the build worktree; CI could not see them. Committed verbatim, plus the two-line type fix at the plan-ask call site. Co-authored-by: cherusk <10729954+cherusk@users.noreply.github.com>
…rray view - one fix each, not both Co-authored-by: cherusk <10729954+cherusk@users.noreply.github.com>
The wish fetch names both tables (its derived-state subquery reads events); the fake served it three-column event rows. Wish-table check first - the failing tests were the fake's fault, not the mirror's. Co-authored-by: cherusk <10729954+cherusk@users.noreply.github.com>
The ported SQL keeps python's leading newline-and-indent; matching from byte zero saw nothing. Trim first. Co-authored-by: cherusk <10729954+cherusk@users.noreply.github.com>
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motion 1 of the rung-10 controller lane (lane-board 10-16): the python test suite (~5.3k lines, 12 files) ported to rust beside the body it arbitrates. The python tests patched execute_query/wmill; the rust seams (DbGateway, WindmillGateway, CausalClient) are the injection point - a shared fake harness under tests/rust, one module per python test file.
IN FLIGHT - this PR grows tranche by tranche; held for review when the suite is complete.
Tranche 1 (this push):
Parity gaps the port caught in the first rust body, cured here against the python reference (python stays the reference until cutover):
Standing rulings honored: SQL byte-stable (two query strings grew the instruments column exactly as python's), envelope key order preserved (instruments sits between liveness and createdAt), CI-only builds.