Repository navigation
feat(rung10): the python dies - body, tests, and their CI jobs - #126
Merged
Merged
Conversation
The create-executor port (#125) was the last python body with a rust twin beside it; per the holder's re-plan the ported rust suite is the parity record, so the python goes in one motion: - controller/ (30 files: the verbs, services, grammars, database layer, both executors) and shared/otel_logging.py - tests/conftest.py + tests/unit/ (12 python test files - every one ported to tests/port across #118/#120/#121/#123/#125) - the two python CI workflows (Controller CI's integration job, Controller Unit Tests) - the rust job (cargo test) is the check Deliberately LEFT for the wiring motions (his queue items 3-5): both component.yamls (the windmill sync specs - they stop matching anything and get rebuilt as header scripts + pointer files), the README (describes the domain, not the file layout), and the windmill path strings f/controller/* (surface contract). Riders, same seam: the now-false "SKIPPED, named: create-executor tests (python leaf)" marker in wishes.rs (they landed in systemtenders.rs with #125), and the three present-tense "the python suite under tests/unit/ is the parity bar / stay the reference until cutover" notes in database.rs, tests/port/main.rs, and tests/rust/main.rs - this suite is the standing record now. The estate is untouched: windmill runs its own synced copies until his reinstall picks up the finished artifact. Co-authored-by: cherusk <10729954+cherusk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The motion (queue item 2, after #125's merge)
Per the holder's re-plan: only he runs the estate, the repo's python has no external readers (windmill runs its own synced script copies), and the ported rust suite is the parity record. The python goes in one motion.
What dies
What deliberately stays (named, for the wiring motions)
Riders, same seam
The estate is untouched: nothing coexists at the reinstall - it picks up the finished artifact (factory image, probe, header scripts still queued).
After this merge, next in order: the factory image in godon-images, the yugabyte probe as an actions job, then header scripts + pointer files.
Co-authored-by: cherusk 10729954+cherusk@users.noreply.github.com