Conversation
vonovak
added this pull request to stack #4432
September 17, 2026 17:52
vonovak
changed the title
This was referenced Sep 17, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## codex/session-teardown-helper #4435 +/- ##
================================================================
Coverage ? 72.43%
================================================================
Files ? 974
Lines ? 46372
Branches ? 9951
================================================================
Hits ? 33583
Misses ? 11794
Partials ? 995 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vonovak
force-pushed
the
codex/graphql-abort-signal
branch
2 times, most recently
from
September 18, 2026 08:09
34c7538 to
db713d1
Compare
vonovak
force-pushed
the
codex/graphql-abort-signal
branch
from
September 18, 2026 10:02
db713d1 to
6a7fb47
Compare
vonovak
force-pushed
the
codex/graphql-abort-signal
branch
from
September 18, 2026 10:19
6a7fb47 to
f6e2e3a
Compare
vonovak
force-pushed
the
codex/graphql-abort-signal
branch
from
September 18, 2026 11:16
f6e2e3a to
3e3a01a
Compare
…etch Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01D29AEWN9ajZXbzobHUH4fF
The artifact upload-session mutation and the sandbox-ready mutation each wrapped fetch by hand to join a cancellation signal after urql set its own. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01D29AEWN9ajZXbzobHUH4fF
vonovak
force-pushed
the
codex/graphql-abort-signal
branch
from
September 18, 2026 11:17
3e3a01a to
a005cd2
Compare
|
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
urql replaces
fetchOptions.signal, so a caller's signal must be joined intofetchafter urql sets its own. Two call sites carried that wrapper by hand.How
graphqlAbortContext(signal)returns a urql context whosefetchjoins both signals, or nothing without a signal. The artifact upload-session and sandbox-ready mutations use it.Stack 5/6, based on #4431, followed by #4441.
Test plan
A unit test aborts the joined request from either side. The real-HTTP cancellation test and the sandbox tests pass through the helper.
🤖 Generated with Claude Code
https://claude.ai/code/session_01D29AEWN9ajZXbzobHUH4fF