Conversation
vonovak
added this pull request to stack #4421
September 17, 2026 15:15
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## codex/android-recording-hardening #4430 +/- ##
====================================================================
Coverage ? 72.42%
====================================================================
Files ? 973
Lines ? 46363
Branches ? 9956
====================================================================
Hits ? 33574
Misses ? 11794
Partials ? 995 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vonovak
removed this pull request from stack #4421
September 17, 2026 16:06
vonovak
added this pull request to stack #4432
September 17, 2026 16:06
This was referenced Sep 17, 2026
vonovak
force-pushed
the
codex/session-host-finish-policy
branch
2 times, most recently
from
September 18, 2026 08:09
ef33dbe to
30cdb41
Compare
vonovak
force-pushed
the
codex/session-host-finish-policy
branch
from
September 18, 2026 10:03
30cdb41 to
fae1412
Compare
A readiness timeout ran the full finish pipeline: a stop request to a server that never came up and a read of a recordings.json that did not exist, each logging a warning unrelated to the real cause. finishAsync now skips finalization and upload for a host that never answered /readyz. Finalization and upload failures are reported to Sentry like the per-recording upload failures one layer down, and the finishAsync contract states that it never rejects. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01D29AEWN9ajZXbzobHUH4fF
vonovak
force-pushed
the
codex/session-host-finish-policy
branch
from
September 18, 2026 10:19
fae1412 to
30d558b
Compare
|
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A host that never answered
/readyzwas finished through the full pipeline, logging a failed stop request and a missingrecordings.jsonon every readiness timeout. Finalization and upload failures were visible only in job logs.How
finishAsync()only stops a host that never became ready.finishAsync()is documented as never rejecting.Stack 3/6, based on #4420, followed by #4431 → #4435 → #4441.
Test plan
The rollback test asserts no stop request, upload or finalize warning after a readiness timeout. The finalization-failure test asserts the Sentry capture.
🤖 Generated with Claude Code
https://claude.ai/code/session_01D29AEWN9ajZXbzobHUH4fF