Repository navigation
feat(poll): adopt ocp 0.7.0 and flipcash2 0.19.0 contracts - #1065
Merged
bmc08gt merged 4 commits intoOct 14, 2026
Merged
Conversation
Wrap CreatePoll, GetPoll, GetPolls and Vote behind FlipClient, with Poll/PollDefinition/PollState domain types and positional Error* enums.
- DmPayment.Action moved to Intent.PaymentAction - group payment chat metadata, CashContent.receiver persisted - poll widget and UserJoined system content fall back as unrecognized - GetBalances skips the per-mint map, only the core total is read
This was referenced Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins ocp-client-protocol 0.7.0 (code-payments/ocp-client-protocol#10) and flipcash2-client-protocol 0.19.0 (code-payments/flipcash2-client-protocol#27), both published, through
Scripts/bump-contract.sh, one commit per package with itsPackage.resolvedentry.Adopts the contract changes:
ChatMetadata.DmPayment.Actionmoved toFlipcash_Intent_V1_PaymentAction.TipDmActionandChatPaymentMetadatawere the only users.PollService,FlipClient+Poll(createPoll,getPoll,getPolls,vote) and domain models inModels/Poll/Poll.swift.ErrorGetPoll,ErrorGetPollsandErrorVotemap positionally from new result enums;ErrorCreatePollfollowsErrorStartChatso.textModeratedcarries the flagged category.PollServiceTestsandTransportClassificationTestscover the mapping.ChatPaymentMetadata.groupPayment(chatID:), serialized with action.send.CashContent.receivermaps toConversationMessage.cashReceiverID. It isn't persisted, so a message read back from the store has it asnil.PollWidgetgets an explicit case in the widget mapping and still renders as an unrecognized widget.SystemContent.typeneeds nothing: the app rendersfallback_text.BalanceServicedoesn't setexclude_per_mint_balances; requests are unchanged. Link previews andMintBalance.quarksaren't mapped yet since nothing reads them.