Repository navigation
refactor(chat): build the attach actions once for both hosts - #1056
Merged
Merged
Conversation
The menu and card callbacks were written out three times: once for the overlay over the keyboard, once as the bar's six parameters, and again when the bar repackaged those into AttachOverlayActions. The copies had already drifted on onAllPhotos, and the overlay kept the value it was handed when it opened, so it never saw a later render's closures. The representable now builds one AttachActions per render and gives it to the bar as a single parameter. The overlay reads it through a closure each time its root renders, and sets onAllPhotos itself, since only a card drawn in the keyboard's window has to hand All Photos to the bar. handOffToBar is private to the overlay as a result.
bmc08gt
added this pull request to stack #1063
October 14, 2026 19:25
bmc08gt
added a commit
that referenced
this pull request
Oct 14, 2026
* commit '16a24ad1eb3eeac2097eac72d32150ba2c368f18': fix(ui): draw UIKit caption in Avenir Medium like SwiftUI (#1064) fix(members): host chip and member count label to match Android (#1058) chore(chat): log the attach lifecycle the same way in both hosts (#1062) refactor(chat): decide attach close events in one place (#1061) refactor(chat): measure the attach card's frame once (#1060) refactor(chat): read the attach menu rows live over the keyboard (#1059) refactor(chat): build the attach actions once for both hosts (#1056) fix(chat): render system messages in the transcript (#1054) # Conflicts: # Flipcash/Core/Screens/Conversation/ChatScreenRepresentable.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The attach menu and card callbacks were written out three times: in
ChatScreenRepresentablefor the overlay over the keyboard, again as six parameters onConversationBottomBar, and a third time when the bar repackaged those intoAttachOverlayActions. The copies had already drifted: only the overlay's setonAllPhotos. The overlay also kept the value it was handed inbegin, so it never saw a later render's closures.AttachOverlayActionsbecomesAttachActionsand moves toAttachSurface.swift, next to the view that draws it, since the bar is a consumer now too.attachActionsparameter in place of the six.onAllPhotosto its own hand-off, because only a card in the keyboard's window can't present the full picker.handOffToBar()is private as a result.No behaviour change intended. All Photos still opens the full picker in place with the keyboard down, and hands the card to the bar with it up.
This and #1053 both edit
attachSurfaceinConversationBottomBar.swift, so whichever merges second needs a rebase.