Repository navigation
fix(chat): render system messages in the transcript - #1054
Merged
Merged
Conversation
Server SystemContent messages map to Content.system(fallbackText:), stored as kind 6 (schemaVersion 51). Blank text is stored as "" and draws no row; the chat-list preview skips blank notices. A notice never counts as unread, never anchors a receipt, and does not trigger the receive haptic.
The divider headed the first non-self message after the read-through, so a system message in the unread run could take it. Place it on the first real message instead, comparing against the nearest real message above.
bmc08gt
added a commit
that referenced
this pull request
Oct 14, 2026
* commit '16a24ad1eb3eeac2097eac72d32150ba2c368f18': fix(ui): draw UIKit caption in Avenir Medium like SwiftUI (#1064) fix(members): host chip and member count label to match Android (#1058) chore(chat): log the attach lifecycle the same way in both hosts (#1062) refactor(chat): decide attach close events in one place (#1061) refactor(chat): measure the attach card's frame once (#1060) refactor(chat): read the attach menu rows live over the keyboard (#1059) refactor(chat): build the attach actions once for both hosts (#1056) fix(chat): render system messages in the transcript (#1054) # Conflicts: # Flipcash/Core/Screens/Conversation/ChatScreenRepresentable.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Private group chats now carry server system messages (
SystemContent, e.g. "A new member joined the group"). iOS threw them away when they arrived (case .system, .none: return nilinConversationMessage), so they never reached the database, the transcript or the chat list.They're now kept as
Content.system(fallbackText:), stored as content kind 6, which bumpsDatabase.schemaVersionto 51.In the transcript they render as
ChatSystemMessageCell: aninfo.circleglyph and the text, centred, inappTextCaptionandtextSecondary, wrapping at 250pt. There's no bubble, sender, timestamp or gestures;MessageCapabilitytreats.systemlike.deleted. Design is option D in the private groups iteration section, node11721:879.How a system row behaves in the transcript:
sys-<stableID>.inboundMessageCountandfirstInboundMessageIDalready exclude kind 6; the in-memory divider placement inChatItem+Conversationnow skips system rows too, with a newUnreadDividerTestscase.buzzesOnReceive), butlatestConfirmedMessagestill includes it, so mark-read sees it.Blank text is trimmed to
""and stored, so read state stays intact, but it renders no row.Chat list: a system message previews as its text with no sender prefix, and the latest-message query skips system messages with empty text.
The encrypted path (
ChatSeal) still drops.system; that's unchanged here.Includes the plan in
.claude/plans/2026-10-14-chat-system-messages.md.Android counterpart: code-payments/code-android-app#1769.