Repository navigation
fix(chat): render system messages in the transcript - #1769
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Private group chats now carry server system messages (
SystemContent, e.g. "A new member joined the group"). They were stored but drawn as an empty row:is MessageContent.System -> Unitstill took the row's spacing, leaving an unexplained gap in the transcript.They now render as
SystemMessageRow: an info glyph and the text, centred, incaptionandtextSecondary, wrapping at 250dp. There's no bubble, sender, timestamp, long-press, reactions, reply or swipe. Design is option D in the private groups iteration section, node11721:879.How a system row behaves in the transcript:
ChatListItem.SystemMessage, keyedsys-<id>.firstNotSentByAfternow requires a sender, matchingcountInboundAfter.ContentBubbleitems.Blank text:
ProtobufToLocaldrops whitespace-onlySystemContentbut keeps the message, so read state and divider ids stay intact, and no row is drawn.Chat list: a system message previews as its text with no sender prefix. The latest-message queries in
ChatMessageDaonow skip messages whose content is empty (content_jsonnull or[]). This applies to any empty-content message, not only system ones, so a chat no longer previews as blank.iOS counterpart: code-payments/code-ios-app#1054.