Repository navigation
chore(theme): share success greens with Android - #1047
Merged
Merged
Conversation
Fill (switch tracks, bubbles, filled icons) is #1AC86A via the success asset; success text and glyphs are #73EAA4 via textSuccess. Switch tints, Bubble and Badge fills, and the E2EE learn-more checkmark move to .success. Sentiment, bannerSuccess and bill colours are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iOS and Android disagree on success green: iOS fills with #34C759 and colours success text #49D517, Android uses #1AC86A for both. This moves iOS onto the shared pair from the Flipcash2 colour spec: #1AC86A for fills and #73EAA4 for text. The Android side is code-payments/code-android-app#1761.
success.colorsetis now sRGB #1AC86A (was display-p3 #34C759). Only the username progress card used it, so no other screen shifts from this.textSuccessis now #73EAA4 (was #49D517).textSuccessas a fill move to.success: the switch tint inBetaFlagToggleRowandSettingsAppSettingsScreen, theBubbledefault, and theBadge"Invited" bubble preview.Color(r: 47, g: 194, b: 107)for.success.textSuccess:WithdrawAddressValidityRow,DialogButton,Badge,CapsuleButton,ImmutableField.Switches used
textSuccessto look like the system switch. They now follow the design system on purpose.Color.Sentiment.positive(#319C58, price up),bannerSuccessand the bill colours are unchanged.