Repository navigation
chore(theme): align Android success greens with the shared tokens - #1761
Merged
Merged
Conversation
Map successText to the declared #73EAA4 so validity text uses the shared text green. Price-up keeps rendering #1AC86A by reading success in CurrencyAppreciationLabel and MarketCapExplainerContent. CodeToggleSwitch now uses the success fill (#1AC86A) instead of SystemGreen, which is removed. The unused ui/resources ic_checked_green (#87D300) now matches the app copy that already won the resource merge. The Flipcash success banner uses the gray bannerThemed.
github-actions
Bot
added
area: ui
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android's theme declares a text green (#73EAA4) but maps
successTextto the fill green, so the declared value never reaches the screen. iOS is moving to the same pair in code-payments/code-ios-app#1047: #1AC86A for fills and #73EAA4 for text.FlipcashDesignSystemmapssuccessTextto #73EAA4.CurrencyAppreciationLabelandMarketCapExplainerContentreadsuccessfor price up, so price up keeps rendering #1AC86A.CodeToggleSwitchusessuccessfor the checked track instead ofSystemGreen(#04C759). Switches usedSystemGreento look like the system switch; they now follow the design system on purpose.SystemGreenhad no other users and is removed.ui/resourcesic_checked_green(#87D300, white checks) now matches theapps/flipcash/corecopy. The app copy already won the resource merge for all three users (checked in the merged debug APK), so nothing changes on screen.bannerThemedinstead ofBannerSuccess(#0F5020), matching iOS.The legacy
CodeDefaultColorSchemestill maps success to #87D300. Nothing renders under it, so it is left alone.