Repository navigation
Conversation
…rs (#481) Both EVENTS catalogs now name cleanup-reaper and nuke in the device.deleted initiator list, matching src/core/cleanup-executor.ts and nuke-service.ts. 3 failing -> 0 failing (the two new tests, each in both catalogs, plus the existing tests still green: 19/19).
Contributor
Author
Review notesNot blocking, not verified. Each is one reviewer's claim.
Written by an agent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #481
Status
Implement: done (4/4 green) Review: round 1 passed Hardware: n/a Gate: running
Next: gate
Done when:
docs/EVENTS.mddevice.deletedrow listscleanup-reaperas an initiator (destroyed in cleanup). Checked bysrc/bus/index.test.ts:294.docs/internal/EVENTS.mddevice.deletedrow listscleanup-reaperas an initiator. Checked bysrc/bus/index.test.ts:294.docs/EVENTS.mdanddocs/internal/EVENTS.mddevice.deletedrows listnukeas an initiator. Checked bysrc/bus/index.test.ts:304.pnpm exec vitest run --project unit src/bus/index.test.tspasses.Assumptions
nukeis also missing from the row is in scope — it is the same row, the same false claim, and the conservative fix is to list both.Review
Spec review: 0 blocking, 0 fixed, 1 notes. Code review: 0 blocking, 0 fixed, 0 notes. Claims review: 0 blocking, 0 fixed, 0 notes.
Rounds: 1. Tokens: 2.4M.
Implementer: Haiku (trial).
Written by an agent.