Repository navigation
Conversation
8 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On M1 Max, both KDA pipelines support only 512 threads, and router variants for 4/6/7/8 rows also fall below their 1,024-thread dispatch. These launches can leave outputs unwritten without a command-buffer error.
Reserve 1,024 threads in the GLM generator and regenerate both KDA kernels and the router. Arithmetic, reduction order and dispatch sizes stay unchanged. Add regressions for every router row count, both KDA head counts, values, state/cache coverage and continuity across windows.
Dependency: This branch includes #704's sparse-attention fix and uses its generator support. Merge #704 first; this PR should then be rebased to leave only the KDA/router commit.
Validated on M1 Max with Zig 0.17.0:
Full-model inference, two-Mac TP2 and other GPUs remain untested. Raw logs remain local.