Repository navigation
Nemotron: fix SSM backward thread limit on M1 - #715
Merged
Merged
Conversation
mrv777
marked this pull request as ready for review
October 12, 2026 03:09
jschmied
pushed a commit
to jschmied/TensorFold
that referenced
this pull request
Oct 13, 2026
Owner
|
Thank you, @mrv777. Gradients left unwritten with no command-buffer error would have been hard to find from a training run, and the new tests pin every shape that matters. Your commit landed in 1.0.9 under your name ( Your gradient checks pass on an M3 Ultra and an M5 Ultra (2 of 2 on each, with the same errors on both chips), and the macOS host suite passes. We haven't timed a Living Weights training step with it; the arithmetic and dispatch are unchanged, so we expect no difference. M1 is your receipt. |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On M1 Max,
tf_train_ssm_backreports a 768-thread limit, but training dispatches 1,024 threads per head. The launch can leave gradients unwritten without a command-buffer error.Declare a 1,024-thread limit and add regressions for gradients, seeded checkpoints, shared groups and checkpoint boundaries, including the production 64-head/8-group shape. Arithmetic and dispatch sizes are unchanged.
Validated on M1 Max with Zig 0.17.0:
This PR is independent of the GLM fixes. Raw logs remain local. Full-model training and other GPUs remain untested.