Repository navigation
[Python] Align Native write validation and file metadata with Java - #10660
Merged
JingsongLi merged 11 commits intoOct 19, 2026
Merged
JingsongLi merged 11 commits into
JingsongLi merged 11 commits into
Conversation
JingsongLi
marked this pull request as ready for review
October 19, 2026 14:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Align existing PyPaimon Native write validation, binary partition naming and data-file creation-time semantics with current Java, and remove unnecessary Native fallback caused by unused context fields.
Depends on apache/paimon-rust#1172 for the corresponding Native behavior fixes. Native CI continues building Rust main; this PR remains draft until the Rust fixes land.
Brief change log
Tests
Review follow-up: real LargeString Arrow write/commit/read regressions and Pandas row-kind/nullability regressions first fail on the old code, then pass. Final focused suite: 56 passed, 44 Native skipped; adjacent writer/schema suites: 207 passed, 169 skipped, 6 subtests passed. Invalid retained INSERTs, PK/sequence NULLs and ordinary append/PK Pandas constructor checks remain covered.
Before the final Pandas-only transport adjustment, full related write/schema/Python 3.6 regressions: 437 passed, 392 skipped, 33 subtests passed. The final changed Python sources pass Flake8, Python 3.6 syntax parsing and diff checks.
Additional Native NULL-transport regressions: 39 passed, 24 Native skipped locally; real PyArrow C Data and WriteState checks pass in the companion Rust binding unit executable (101 tests).
New ignored nested-value write/read matrix: 15 passed, 15 Native skipped locally.
Related write/schema/Python 3.6 regressions: 418 passed, 349 skipped, 33 subtests passed.
Independent review caught and closed LargeUtf8, InternalRow kind, retained nested-schema and schema-only writer edge cases.
New related writer regressions: 135 passed, 8 subtests; commit/creation-time regressions: 58 passed, 3 Native skipped, 10 subtests (one unrelated optional Lance case deselected).
Final creation-time regression rerun (both file orders): 22 passed, 6 Native skipped.
Previously verified related Python regressions: 247 passed, 234 Native skipped, 44 subtests passed. Restored Native-plan regression suite: 68 passed, 44 subtests passed.
Standard REST authorization and custom-hook fallback, commit, Native vector context, binary partitions, real REST creation-time statistics, exact Avro timestamps and Pure writer metadata roundtrips.
Java InternalRowPartitionComputerTest: 5 passed; Java sources are unchanged since the verified Checkstyle/Spotless run.
All changed Python files pass repository Flake8 and Python 3.6 syntax parsing; diff checks pass.
Companion Rust core, writer and Python-binding Rust unit suites plus pinned Clippy and rustfmt.
Local Python tests did not rebuild or install the Native extension. Native cases remain enabled for CI with the Rust behavior fixes.