Repository navigation
[hotfix] Update the Spark DDL test for binary partitions with the legacy name - #10670
Closed
LuciferYang wants to merge 1 commit into
Closed
LuciferYang wants to merge 1 commit into
LuciferYang wants to merge 1 commit into
Conversation
Contributor
Author
|
cc @JingsongLi |
Contributor
Author
|
Superseded by #10676, which makes the same change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
#10660 changed
InternalRowPartitionComputerto write binary partition names as UTF-8 strings withpartition.legacy-name = trueas well.DDLTestBase"Fix partition column generate wrong partition spec" still expected reading such a table to throw, so it fails on master in every Spark job (Spark 3 / Scala 2.12 and 2.13, Spark 4 / Scala 2.13), for example in https://github.com/apache/paimon/actions/runs/39268515175.The test now checks the same result for both settings: the row reads back and the file sits under
day=2021.Tests
DDLTestBase"Fix partition column generate wrong partition spec".API and Format
no
Documentation
no