Skip to content

fix(honeydew): name the Ossie document in the missing-name error #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbonofre merged 1 commit into from
Sep 27, 2026
Merged

fix(honeydew): name the Ossie document in the missing-name error #420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion converters/honeydew/src/ossie_honeydew/converter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ def convert_ossie_to_honeydew(ossie_yaml_str: str) -> dict[str, str]:
def _model_to_files(sm: dict[str, Any]) -> dict[str, str]:
name = sm.get("name")
if not name:
raise HoneydewConversionError("Missing 'name' in semantic model")
raise HoneydewConversionError("Missing 'name' in Ossie document")

files: dict[str, str] = {}

Expand Down
6 changes: 3 additions & 3 deletions converters/honeydew/tests/test_ossie_honeydew_converter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,9 +599,9 @@ def test_ossie_to_honeydew_invalid_version_raises():
convert_ossie_to_honeydew("version: '9.9.9'\nname: m\n")


def test_ossie_to_honeydew_missing_model_name_raises():
with pytest.raises(HoneydewConversionError):
convert_ossie_to_honeydew(f"version: '{OSSIE_VERSION}'\n")
def test_ossie_to_honeydew_missing_name_raises():
with pytest.raises(HoneydewConversionError, match="Missing 'name'"):
convert_ossie_to_honeydew(f"version: '{OSSIE_VERSION}'\ndatasets: []\n")


@pytest.mark.parametrize(
Expand Down
Loading