Repository navigation
fix(honeydew): name the Ossie document in the missing-name error - #420
Merged
Merged
Conversation
1 task done
baruchoxman
force-pushed
the
honeydew-flat-schema
branch
from
September 18, 2026 12:50
9226911 to
334105e
Compare
Contributor
Author
|
@jbonofre would appreciate you taking a look |
jbonofre
self-requested a review
September 18, 2026 13:02
Member
|
@baruchoxman absolutely. Thanks! |
jbonofre
requested changes
Sep 27, 2026
jbonofre
left a comment
jbonofre
left a comment
Member
There was a problem hiding this comment.
We also have to rebase and resolve conflicts.
Rebased onto main after apache#396 migrated the converter to flat documents; that change already covers the flat read/write, the root dialects/vendors guard, and the legacy wrapper rejection. What remains: the missing-name error refers to the Ossie document rather than a semantic model, and its test asserts the message on an otherwise-valid flat document. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
baruchoxman
force-pushed
the
honeydew-flat-schema
branch
from
September 27, 2026 07:19
334105e to
865041a
Compare
baruchoxman
changed the title
Contributor
Author
|
@jbonofre thanks for the review. I rebased onto main and resolved the conflicts. Since #396 has landed, the flat-document migration and all three of your suggestions are on main already, so I dropped the overlapping changes. What remains is a small fix: the missing- |
jbonofre
approved these changes
Sep 27, 2026
jbonofre
left a comment
jbonofre
left a comment
Member
There was a problem hiding this comment.
Thanks @baruchoxman for the rebase and cleanup! LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased onto
mainafter #396, which already migrated the Honeydew converter to flat semantic model documents: flat read/write, rejecting rootdialects/vendors, and rejecting legacysemantic_modelwrappers.What remains in this PR:
nameerror now refers to the Ossie document instead of a "semantic model", which no longer exists as a wrapper.test_ossie_to_honeydew_missing_name_raisesasserts the error message, using an otherwise valid flat document (datasets: []), so it fails for the intended reason.🤖 Generated with Claude Code