Skip to content

fix inverted boolean to number conversion in InfoSetUtil.doubleValue #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SABITHSAHEB wants to merge 1 commit into
base: master
Choose a base branch
from
+14 −1
Open

fix inverted boolean to number conversion in InfoSetUtil.doubleValue #293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/apache/commons/jxpath/ri/InfoSetUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ public static double doubleValue(final Object object) {
return ((Number) object).doubleValue();
}
if (object instanceof Boolean) {
return ((Boolean) object).booleanValue() ? 0.0 : 1.0;
return ((Boolean) object).booleanValue() ? 1.0 : 0.0;
}
if (object instanceof String) {
if (object.equals("")) {
Expand Down
13 changes: 13 additions & 0 deletions src/test/java/org/apache/commons/jxpath/ri/compiler/CoreFunctionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,19 @@ void testCoreFunctions() {
assertXPathValue(context, "round(2 div 0)", Double.valueOf(Double.POSITIVE_INFINITY));
}

@Test
void testBooleanToNumberConversionIsXPathConformant() {
// XPath number(true())=1 and number(false())=0; the numeric coercion used by arithmetic,
// relational operators and floor/ceiling/round must agree with number(), not invert it.
assertXPathValue(context, "$bool_true + 1", Double.valueOf(2));
assertXPathValue(context, "$bool_false + 1", Double.valueOf(1));
assertXPathValue(context, "floor($bool_true)", Double.valueOf(1));
assertXPathValue(context, "ceiling($bool_false)", Double.valueOf(0));
assertXPathValue(context, "round($bool_true)", Double.valueOf(1));
assertXPathValue(context, "$bool_true > 0.5", Boolean.TRUE);
assertXPathValue(context, "$bool_false > 0.5", Boolean.FALSE);
}

@Test
void testNumberConversionIsXPathConformant() {
// Java number literals that are outside the XPath 1.0 number grammar must convert to NaN.
Expand Down