Repository navigation
fix inverted boolean to number conversion in InfoSetUtil.doubleValue - #293
Open
SABITHSAHEB wants to merge 1 commit into
Open
SABITHSAHEB wants to merge 1 commit into
SABITHSAHEB wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
truereturns0.0andfalsereturns1.0, the opposite of XPath 1.0 (boolean true converts to 1, false to 0) and ofnumber()directly below it andBasicTypeConverter, which both map true to 1 and false to 0.<,>,<=,>=),floor/ceiling/roundand thesubstringindex arguments, so any comparison or arithmetic that coerces a boolean-valued node or variable is evaluated with the operand negated; a predicate such asnode[flag > 0]then selects the wrong set of nodes on caller-supplied data, whilenumber($flag)on the same value returns the correct result.Swapped the two constants so doubleValue agrees with
number()and the spec. Added aCoreFunctionTestcase over the doubleValue path (arithmetic, relational, floor/ceiling/round) that fails before the change and passes after.mvn; that'smvnon the command line by itself.