Skip to content

Preserve the object cache on ordinary redirects #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
JanJakes wants to merge 1 commit into
base: trunk
Choose a base branch
from
Draft

Preserve the object cache on ordinary redirects #525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions packages/plugin-sqlite-database-integration/activate.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,23 +48,23 @@ function sqlite_activation() {

sqlite_plugin_copy_db_file();

// Flush the cache at the last moment before switching databases.
add_filter(
'x_redirect_by',
function ( $result ) {
wp_cache_flush();
return $result;
},
PHP_INT_MAX,
1
);

// WordPress will automatically redirect to the install screen here.
wp_redirect( admin_url() );
exit;
}
add_action( 'admin_init', 'sqlite_activation' );

// Flush the cache at the last moment before the redirect.
add_filter(
'x_redirect_by',
function ( $result ) {
wp_cache_flush();
return $result;
},
PHP_INT_MAX,
1
);

/**
* Add the db.php file in wp-content.
*
Expand Down
49 changes: 49 additions & 0 deletions tests/phpunit/WP_SQLite_Database_Integration_Authorization_Test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,26 @@ public function test_other_plugin_activation_does_not_redirect() {
$this->assertNull( $this->get_activation_redirect( 'another-plugin/plugin.php' ) );
}

/**
* @dataProvider data_redirect_users
*/
public function test_unrelated_redirect_preserves_cache( $role ) {
$user_id = null === $role ? 0 : self::factory()->user->create( array( 'role' => $role ) );
wp_set_current_user( $user_id );

sqlite_activation();

$this->assert_redirect_preserves_cache();
}

public static function data_redirect_users() {
return array(
'anonymous' => array( null ),
'subscriber' => array( 'subscriber' ),
'administrator' => array( 'administrator' ),
);
}

/**
* @group ms-excluded
*/
Expand All @@ -205,6 +225,7 @@ public function test_confirm_install_is_ignored_on_another_page() {
$_REQUEST = $_GET;

$this->assertNull( sqlite_activation() );
$this->assert_redirect_preserves_cache();
}

/**
Expand Down Expand Up @@ -827,6 +848,9 @@ private function assert_valid_nonce_reaches_install_redirect() {
$redirect_reached = false;
$filter = function ( $location ) use ( &$redirect_url ) {
$redirect_url = $location;
wp_cache_set( 'sqlite_redirect_test', 'cached during redirect' );
// Run the final redirect filter without sending headers or exiting the test.
$this->assertSame( 'WordPress', apply_filters( 'x_redirect_by', 'WordPress', 302, $location ) );
throw new RuntimeException( 'Install redirect reached.' );
};

Expand All @@ -844,6 +868,7 @@ private function assert_valid_nonce_reaches_install_redirect() {

$this->assertTrue( $redirect_reached, 'The install request did not redirect.' );
$this->assertSame( admin_url(), $redirect_url );
$this->assertFalse( wp_cache_get( 'sqlite_redirect_test' ), 'The database switch must flush the cache.' );
}

private function assert_valid_nonce_install_is_denied() {
Expand All @@ -870,6 +895,7 @@ private function assert_valid_nonce_install_is_denied() {

$this->assertFalse( $nonce_checked, 'The capability check must run before nonce validation.' );
$this->assertSame( $dropin_before, file_get_contents( WP_CONTENT_DIR . '/db.php' ) );
$this->assert_redirect_preserves_cache();
}

private function assert_invalid_nonce_is_denied() {
Expand All @@ -893,6 +919,29 @@ private function assert_invalid_nonce_is_denied() {
}

$this->assertTrue( $nonce_checked );
$this->assert_redirect_preserves_cache();
}

private function assert_redirect_preserves_cache() {
$using_external_cache = (bool) wp_using_ext_object_cache();
// Route transients through the object cache, as with a persistent cache drop-in.
wp_using_ext_object_cache( true );

try {
wp_cache_set( 'sqlite_redirect_test', 'cached value' );
set_transient( 'sqlite_redirect_test', 'transient value', MINUTE_IN_SECONDS );
set_site_transient( 'sqlite_redirect_test', 'site transient value', MINUTE_IN_SECONDS );

$this->assertSame( 'WordPress', apply_filters( 'x_redirect_by', 'WordPress', 302, wp_login_url() ) );
$this->assertSame( 'cached value', wp_cache_get( 'sqlite_redirect_test' ) );
$this->assertSame( 'transient value', get_transient( 'sqlite_redirect_test' ) );
$this->assertSame( 'site transient value', get_site_transient( 'sqlite_redirect_test' ) );
} finally {
wp_cache_delete( 'sqlite_redirect_test' );
delete_transient( 'sqlite_redirect_test' );
delete_site_transient( 'sqlite_redirect_test' );
wp_using_ext_object_cache( $using_external_cache );
}
}

private function set_install_request( $nonce ) {
Expand Down
Loading